Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[leo_storage] watchdog for slow processing/timeout always enabled #912

Closed
mocchira opened this issue Oct 27, 2017 · 1 comment
Closed

[leo_storage] watchdog for slow processing/timeout always enabled #912

mocchira opened this issue Oct 27, 2017 · 1 comment
Assignees
@mocchira
Labels
Improve _leo_storage Priority-MIDDLE
Milestone
1.3.8

Comments

@mocchira
Copy link
Member

Also no error log is dumped even when it's fired.

TODO

  • make it configurable through leo_storage.conf
  • dump error log when it's fired
@mocchira mocchira added this to the 1.3.8 milestone Oct 27, 2017
@mocchira mocchira self-assigned this Oct 27, 2017
@mocchira mocchira mentioned this issue Oct 27, 2017
Closed
@mocchira
Copy link
Member Author

mocchira commented Nov 2, 2017

turned out that just disabling leo_storage_watchdog_msgs cause erlang to crash in case timeout/slow operation(s) keep happening because the accumulated messages stored in leo_storage_msg_collector never be freed.
https://github.com/leo-project/leofs/blob/develop/apps/leo_storage/src/leo_storage_watchdog_msgs.erl#L161 leo_storage_msg_collector:clear/0 should be called not at leo_storage_watchdog_msgs but some other place like leo_storage_msg_collector itself by timer:send_after

mocchira added a commit to mocchira/leofs that referenced this issue Nov 7, 2017
@mocchira
storage: Fir for leo-project#912
18ee0ee
mocchira added a commit to mocchira/leofs that referenced this issue Nov 7, 2017
@mocchira
storage: Fix for leo-project#912
d0bee7b
@mocchira mocchira mentioned this issue Nov 7, 2017
Merged
@mocchira mocchira closed this as completed Nov 8, 2017
@vstax vstax mentioned this issue Nov 8, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mocchira mocchira

Labels
Improve _leo_storage Priority-MIDDLE
Projects
None yet
Milestone
1.3.8
Development

No branches or pull requests
1 participant
@mocchira