-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update wrap functionality #104
Open
dmitry-prohorov
wants to merge
5
commits into
leoforfree:master
Choose a base branch
from
dmitry-prohorov:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In latest node versions fs.write(fd, string[, position[, encoding]], callback) The callback parameter is no longer optional. Not passing it will throw a TypeError at runtime.
fix(promt): fix issues with fs.write
Wrap only separate lines with 100 character limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! lgtm, we merge when test passes. Please commit as a fix
too. 👏 👏 👏
@@ -32,18 +34,35 @@ const addType = (type, config) => { | |||
return _.trim(`${prefix}${type}${suffix}`); | |||
}; | |||
|
|||
const addBreaklinesIfNeeded = (value, breaklineChar = defaultBreaklineChar) => | |||
value | |||
const addBreaklinesIfNeededAndWrap = (value = '', config) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that sounds perfect to me! thanks for the fix!
@leonardoanalista done |
leonardoanalista
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this amazing tool!
When I try to use this tool and describe my body with
breaklineChar
feature I've faced trouble. You are wrapping the entire body into 100 characters lines and after that add break lines. So if I type1. update description|2. add commit message format section|3. add docker section|4. add commit helper tool section
into the body I will see next result (which is not expected)But I want to see