-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ticket-number question #51
feat: add ticket-number question #51
Conversation
now users can configure a ticket-number question before the subject ISSUES CLOSED: leoforfree#50
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 5
Lines ? 330
Branches ? 0
=======================================
Hits ? 330
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Simon!
Thanks for the PR, I agree with most of things and happy to merge soon. I left questions regarding to the ticket label scenarios. I'll get a second opinion if possible. There could be edge cases from other scenarios.
Hey guys is there a chance this PR can make it in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I've just resolved the conflicts and it is ready to be released 👍 |
🎉 This PR is included in version 5.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@smollweide, @leonardoanalista thank you guys you made my day! |
sorry for the delay, I'll try to be more active on PR's form now on 👍 |
now users can configure a ticket-number question before the subject
ISSUES CLOSED: #50