Allow to automatically determine an existing glossary for DeepL #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjaeger
commented
Sep 9, 2024
README.md
Outdated
There was a problem hiding this comment.
Updated the README with the latest command-line parameter options
fjaeger
commented
Sep 9, 2024
| async getGlossary(from: string, to: string, recreate = false) { | ||
| const allGlossaries = await this.listGlossaries(); | ||
| let glossary = allGlossaries | ||
| .filter((g) => (!!this.appName ? g.name === this.appName : true)) // Only of this app, if defined |
There was a problem hiding this comment.
Matching of appName is now optional (if provided)
leolabs
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, DeepL glossaries are not forced to be re-created each time. Instead, by just using
-gwithout specifying a glossaries directory, an existing DeppL glossary is determined/matched and used in all translations