Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The command should fail if post-success fails #40

Closed
mlazowik opened this issue Jun 3, 2017 · 1 comment · Fixed by #42
Closed

The command should fail if post-success fails #40

mlazowik opened this issue Jun 3, 2017 · 1 comment · Fixed by #42
Labels
bug

Comments

@mlazowik
Copy link
Contributor

mlazowik commented Jun 3, 2017

To reproduce try running with --post-success "gibberish".

This is important, because otherwise your ci builds will succeed even if, for example, npm publish fails.
mlazowik added a commit to qedsoftware/corp-semantic-release that referenced this issue Jun 3, 2017
@mlazowik
fix(process): fail if any of the steps fails
fb220d1 
* fix --post-success option description
* add a new --mock-push option for testing purposes
* add a test for successful post-success invocation

BREAKING CHANGE:
If pre-commit, git push or post-commit fails the whole program will also now fail with non-0 exit
code.

ISSUES CLOSED: leonardoanalista#40
mlazowik added a commit to qedsoftware/corp-semantic-release that referenced this issue Jun 3, 2017
@mlazowik
fix(process): fail if any of the steps fails
a16b6b5 
* fix --post-success option description
* add a new --mock-push option for testing purposes
* add a test for successful post-success invocation

BREAKING CHANGE:
If pre-commit, git push or post-commit fails the whole program will also now fail with non-0 exit
code.

ISSUES CLOSED: leonardoanalista#40
@mlazowik mlazowik mentioned this issue Jun 3, 2017
Merged
@leonardoanalista
Copy link
Owner

Hi Michal, Fyi this is the PR which introduced the post-success as normal script, not necessarily npm script.
https://github.com/leonardoanalista/corp-semantic-release/pull/36/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(process): fail if any of the steps fails qedsoftware/corp-semantic-release
2 participants
@leonardoanalista @mlazowik