-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue66 with ci-skip parameter #71
Conversation
users can specify whether or not CI scripts should be run
unit test for --ci parameter
# Conflicts: # src/index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FranzNieschalk thanks for the PR. It looks good to me.
Thanks again for the PR! I merged and changed the a braking change if you don't mind. The default true could affect existing users upgrading to this version. |
@leonardoanalista Thank you for accepting and merging this PR. Could you release these changes on npm? |
Think this didn’t get released again. I’ll need to look at this issue in the next few days |
@leonardoanalista Bumping for new release (sorry for that). |
It seems like the latest commit release didn't work. See #71 (comment)
It seems like the latest commit release didn't work. See #71 (comment)
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Continuing the work of @Biboba, I checked out his
issue66
branch, addressing your feedback from #67:ci-skip
false
Hope it closes #66, we need this feature desperately.