Remove the --first-parent option from log list generation
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--first-parent` can lose commits in a workflow with multiple merges to reach the branch where changelogs are generated.
gigabo
added a commit
to redfin/react-server
that referenced
this pull request
May 31, 2016
Needs lerna/lerna-changelog#13 to pull through merge.
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
Needs lerna/lerna-changelog#13 to pull through merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--first-parentcan lose commits in a workflow with multiple merges to reach the branch where changelogs are generated.I ran into this generating changelogs on react-server's
nextbranch. We've been merging non-breaking PRs straight to master, and periodically merging master intonext, where we're staging a version with breaking changes. When I runlerna-changeloginnextit doesn't include changes from the PRs that were merged straight to master (without this patch).