Abort process when github response is not OK #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
nm-handle-401-responses
branch
from
eb541df to
cccc244
Compare
Turbo87
changed the title
Turbo87
approved these changes
Dec 16, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
This was referenced Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently bumped into this case where my github token was not valid anymore. When I run
lerna-changelog, there no error an no output and it took me a bit of debugging to figure out that my token was not valid anymore.This PR fixes the response handling by throwing an error in case the response is not successful.