Convert to TypeScript #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzoo any comments? |
hzoo
reviewed
Jun 6, 2017
| "rimraf": "^2.5.4" | ||
| "rimraf": "^2.5.4", | ||
| "ts-jest": "^20.0.4", | ||
| "tslint": "^5.3.2", |
There was a problem hiding this comment.
I was going to say you can try eslint + typescript parser + prettier now instead but can do that later
There was a problem hiding this comment.
yeah, I'd like to postpone that for now and focus on the other commits I still have in the pipeline. I'll keep it in mind for later though.
hzoo
reviewed
Jun 6, 2017
src/ConfigurationError.ts
Outdated
| this.name = "ConfigurationError"; | ||
| this.message = message; | ||
| this.stack = (new Error()).stack; | ||
| export default class ConfigurationError { |
There was a problem hiding this comment.
didn't really like extending built-ins ever but ok 😄 (can you remove the comments and code below)?
hzoo
approved these changes
Jun 6, 2017
|
since Travis is still 🍏 after addressing the comments I'll merge this and prepare the next PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
anytype is still used quite a lot, but this is a first step that allows us to use better type interfaces as discussed via Slack.