Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract "MarkdownRenderer" class #65

Merged
merged 21 commits into from
Jun 18, 2017
Merged

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jun 13, 2017

This finally splits the markdown rendering from the data gathering code. This PR only includes the extraction. Once this is merged I have a few more commits that clean up the new renderer class and test it properly.

@Turbo87 Turbo87 requested a review from hzoo June 13, 2017 15:36
@DxCx
Copy link

DxCx commented Jun 15, 2017

👍 for this one. thanks @Turbo87 i was looking for exactly that =)

@ohadgk
Copy link

ohadgk commented Jun 16, 2017

thanks @Turbo87, me too!

Copy link
Contributor

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@hzoo hzoo merged commit 16aabc7 into lerna:master Jun 18, 2017
@Turbo87 Turbo87 mentioned this pull request Jun 19, 2017
@Turbo87 Turbo87 deleted the markdown-renderer branch June 21, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants