Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download PhantomJS from CDN #2905

Merged
merged 3 commits into from
Jun 1, 2016
Merged

Download PhantomJS from CDN #2905

merged 3 commits into from
Jun 1, 2016

Conversation

abrobston
Copy link
Contributor

Addresses #2898. Instead of attempting a manual download of
PhantomJS, use the npm package phantomjs-prebuilt and the
environment variable PHANTOMJS_CDNURL as suggested in
the comment at ariya/phantomjs#13953 (comment).

@abrobston
Download PhantomJS from CDN
726cd96 
Addresses less#2898.  Instead of attempting a manual download of
PhantomJS, use the npm package phantomjs-prebuilt and the
environment variable `PHANTOMJS_CDNURL` as suggested in
the comment at
ariya/phantomjs#13953 (comment).
@abrobston
Copy link
Contributor Author

The good news is that PhantomJS appears to donwload now, eventually. The bad news is that the build still fails due to peer dependency problems involving Grunt:

npm ERR! peerinvalid The package grunt@1.0.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer jit-grunt@0.10.0 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-contrib-concat@1.0.1 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-shell@1.3.0 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-contrib-connect@1.0.2 wants grunt@>=0.4.0
npm ERR! peerinvalid Peer grunt-saucelabs@8.6.2 wants grunt@~0.4.1
npm ERR! peerinvalid Peer grunt-contrib-clean@1.0.0 wants grunt@>= 0.4.5
npm ERR! peerinvalid Peer grunt-contrib-jshint@1.0.0 wants grunt@>=0.4.0

The error appears in all the build configurations on both Travis and Appveyor.

The issue appears to be that the latest published version of grunt-saucelabs has a peer dependency incompatible with Grunt 1+. The latest GitHub version does appear to have this compatibility, however.

My suggestion would be to use an earlier version of Grunt until grunt-saucelabs catches up. I will try this addition in a new commit to the pull-request branch shortly.

@abrobston
Roll back Grunt to version 0.4.5
e29f7de 
Continuous-integration builds now fail due to peer-dependency
issues.  It appears that the `grunt-saucelabs` package does not
currently work with Grunt 1+.  Future versions likely will, but for
now, rolling back to Grunt ~0.4.5 may allow the CI builds to
progress.
@abrobston
Copy link
Contributor Author

One of the Travis builds had a connection reset when downloading PhantomJS this time. The other three builds, plus all the Appveyor builds, passed. Maybe there is a better mirror... but for now, maybe some builds will succeed?

@abrobston abrobston mentioned this pull request May 31, 2016
Closed
@matthew-dean
Copy link
Member

Since you seem to know a bit about this, what Node versions should be setup to be tested in the yml file? I think you can set it up to do latest, and I believe the Node versions don't need minor versions (so will test the latest 4.x and 6.x with just "4" and 6" I think?). Do you think you could look into that?

@abrobston
Copy link
Contributor Author

That is correct. I'll revise .travis.yml and commit shortly. There have been some compatibility issues with Node 6 and certain packages, I know.

@matthew-dean
Copy link
Member

@abrobston Thanks very much. Less could certainly use some help on the releasing / testing / builds side of things.

@abrobston
Test against latest Node 4 and 6
d6bd0e9 
Update .travis.yml to test against the latest Node release within
versions 4.x and 6.x (as well as 0.10 and 0.12 still).  Update
appveyor.yml to add Node 6 to the list of environments.
@abrobston
Copy link
Contributor Author

It appears that Node 6 presented no issues.

@matthew-dean
Copy link
Member

Looks good, thanks!

@matthew-dean matthew-dean merged commit cc1a143 into less:master Jun 1, 2016
@abrobston abrobston deleted the bug2898 branch June 1, 2016 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrobston @matthew-dean