Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3.x into master #3163

Merged
merged 117 commits into from
Feb 11, 2018
Merged

Merge 3.x into master #3163

merged 117 commits into from
Feb 11, 2018

Conversation

matthew-dean
Copy link
Member

No description provided.

matthew-dean and others added 30 commits June 24, 2016 20:36
- Add visitor iterator so that visitors can be added while visiting (such as plugins in nested scope)
…he plugin is declared to be passed into the plugin after it is evaluated. (Useful for creating function calls / vars dynamically.)
- Added tree shim for old node types and plugin visitor shim to upgrade node visitors to new node types
- Inline JavaScript disabled by default
- Deprecated "preprocessor" option removed (preprocessor plugins still valid)
* feature/@plugin:
  All tests passing for @plugin - Inline JavaScript disabled by default - Deprecated "preprocessor" option removed (preprocessor plugins still valid)
  Plugin loader set up for lessc, node, and browser
- Create Anonymous nodes from non-null (but non-Node) function return values
- Allow empty Anonymous nodes to collapse on output
…ue parsing

i.e. All values are anonymous strings until "queried"
- Unlike original PR, no change in existing test output for un-referenced properties
- unused variables would theoretically result in a tiny improvement in parsing time
e.g. "less.Ruleset()" instead of "new less.tree.Ruleset()"

Auto-casting of string values into nodes for AtRule, Declaration, Selector, Value
e.g. "less.Selector('&.a')" instead of "new tree.Selector(new tree.Element(new tree.Combinator('&'), '.a'))"
In Short:
* Enable Travis Cache to mitigate phantomjs download issues.
* Enable Travis & appveyor <retry> functionality to avoid race condition on CI builds
  and old node.js version (0.10/0.12)

Details:

Using <https://bitbucket.org/ariya/phantomjs/downloads/>
to download phantom (on travis)  instead of <http://cnpmjs.org/downloads>
because Travis downloads from http://cnpmjs.org/downloads are horribly slow (30k/s)
and seem courrpt most of the time (smells like throttling)

Travis caching is by branch + build env (node version).
But it has a fallback to using the cache from the default branch
so it should help even with pull requests (which are new branches).

Secondly using <travis_retry> and <appveyor_retry> for <npm install>
to workaround race condition on with npm install and older versions of node.

mitigates less#2898
matthew-dean and others added 26 commits October 9, 2017 22:13
Drop node 0.10 and 0.12 and added node 9 matrix testing
- Remove UMD spec from plugins
- Add simple grid syntax support
@matthew-dean matthew-dean merged commit 45d06b9 into less:master Feb 11, 2018
Krinkle added a commit to wikimedia/less.js that referenced this pull request Jul 15, 2024
Follows-up a38f8a1, which introduced
this as part of implementing property accessors. The method was not
used there, and hasn't been used elsewhere since then either.

Ref less#3163.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants