-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2991 #3649
Fix #2991 #3649
Conversation
Test failure seems to be a change of formatting of an error message in node 16. I don't see any relation to my changes.
|
@MoonCoral Yes, it's not your issue. |
@MoonCoral Please update your branch, upstream master branch solved the CI problem. |
Rebased on master |
@MoonCoral CI has been fixed, please update your work, thanks ! |
If all other tests pass, this seems good. |
Closes #2991
Only comments have
isSilent
as far as I could see. No comment should cause a parent to be printed in the 'referenced' case.Thus I'm not even sure what the condition I deleted aimed to achieve.
Test is based on the snipped posted in #2991.
css-3.css
contained an empty@
rule, I assume to bypass the issue raised in #2991.