Rename the old WithMaxBufferSize option as previously warned (#1218)

Co-authored-by: Daisuke Maki <lestrrat+github@users.noreplay.github.com>

jwe/jwe.go

@@ -43,7 +43,7 @@ func Settings(options ...GlobalOption) {
 			maxPBES2Count = option.Value().(int)
 		case identMaxDecompressBufferSize{}:
 			maxDecompressBufferSize = option.Value().(int64)
-		case identMaxBufferSize{}:
+		case identCBCBufferSize{}:
 			aescbc.SetMaxBufferSize(option.Value().(int64))
 		}
 	}

jwe/jwe_test.go

@@ -807,10 +807,10 @@ func TestGHSA_7f9x_gw85_8grf(t *testing.T) {
 	}
 }
 
-func TestMaxBufferSize(t *testing.T) {
+func TestCBCBufferSize(t *testing.T) {
 	// NOTE: This has GLOBAL EFFECT
-	jwe.Settings(jwe.WithMaxBufferSize(1))
-	defer jwe.Settings(jwe.WithMaxBufferSize(0))
+	jwe.Settings(jwe.WithCBCBufferSize(1))
+	defer jwe.Settings(jwe.WithCBCBufferSize(0))
 
 	key, err := jwxtest.GenerateRsaJwk()
 	require.NoError(t, err, `jwxtest.GenerateRsaJwk should succeed`)

jwe/options.yaml

@@ -159,15 +159,13 @@ options:
       This option can be used for `jwe.Settings()`, which changes the behavior
       globally, or for `jwe.Decrypt()`, which changes the behavior for that
       specific call.
-  - ident: MaxBufferSize
+  - ident: CBCBufferSize
     interface: GlobalOption
     argument_type: int64
     comment: |
-      WithMaxBufferSize specifies the maximum buffer size for internal
+      WithCBCBufferSize specifies the maximum buffer size for internal
       calculations, such as when AES-CBC is performed. The default value is 256MB.
       If set to an invalid value, the default value is used.
+      In v2, this option was called MaxBufferSize.
 
       This option has a global effect.
-
-      Due to historical reasons this option has a vague name, but in future versions
-      it will be appropriately renamed.