Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook in jwa.RegisterXXX functions with jws.Register(Signer|Verifier) #911

Merged
merged 6 commits into from
Apr 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
go_tags: [ 'stdlib', 'goccy', 'es256k', 'alltags']
go: [ '1.19', '1.18', '1.17' ]
go: [ '1.20', '1.19', '1.18']
name: "Test [ Go ${{ matrix.go }} / Tags ${{ matrix.go_tags }} ]"
steps:
- name: Checkout repository
Expand Down Expand Up @@ -57,7 +57,8 @@ jobs:
uses: codecov/codecov-action@v3
with:
file: ./coverage.out
- uses: bazelbuild/setup-bazelisk@v2
- run: bazel run //:gazelle-update-repos
- name: Check difference between generation code and commit code
run: make check_diffs
- uses: bazelbuild/setup-bazelisk@v2
- run: bazel build //...

12 changes: 12 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@ Changes
v2 has many incompatibilities with v1. To see the full list of differences between
v1 and v2, please read the Changes-v2.md file (https://github.com/lestrrat-go/jwx/blob/develop/v2/Changes-v2.md)

v2.0.10 - UNRELEASED
[Bug fixes]
* Registering JWS signers/verifiers did not work since v2.0.0, because the
way we handle algorithm names changed in 2aa98ce6884187180a7145b73da78c859dd46c84.
(We previously thought that this would be checked by the example code, but it
apparently failed to flag us properly)

The logic behind managing the internal database has been fixed, and
`jws.RegisterSigner` and `jws.RegisterVerifier` now properly hooks into the new
`jwa.RegisterSignatureAlgorithm` to automatically register new algorithm names
(#910, #911)

v2.0.9 - 21 Mar 2023
[Security Fixes]
* Updated use of golang.org/x/crypto to v0.7.0
Expand Down
58 changes: 44 additions & 14 deletions jwa/compression_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

66 changes: 48 additions & 18 deletions jwa/content_encryption_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 49 additions & 19 deletions jwa/elliptic_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

88 changes: 59 additions & 29 deletions jwa/key_encryption_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading