[17.0][MIG] account_invoice_start_end_dates: Migration to 17.0 #4

lethuthao2403 · 2023-11-28T08:38:05Z

No description provided.

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

…art_end_dates: fixing tests fixing product not found convert mline dates to string fixing flake8 account_invoice_start_end_dates: fixing tests fixing product not found convert mline dates to string fixing flake8 putting removed licences back fix tests fix flake8 fix pylint issues [12.0-mig-account] fix unit tests fixup! [12.0-mig-account] fix unit tests fixup! fixup! [12.0-mig-account] fix unit tests

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-12.0/account-closing-12.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_invoice_start_end_dates/

Default value for cutoff date is end date of previous fiscal year

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-13.0/account-closing-13.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-13-0/account-closing-13-0-account_invoice_start_end_dates/

Currently translated at 88.2% (15 of 17 strings) Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/fr_FR/

Currently translated at 100.0% (14 of 14 strings) Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/pt/

Currently translated at 100.0% (14 of 14 strings) Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/it/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/

Remove deprecated POT files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/es/

Currently translated at 92.3% (12 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/hr/

Currently translated at 100.0% (13 of 13 strings) Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/

Co-authored-by: Alexis de Lattre <alexis@via.ecp.fr>

nguyenminhchien

Pre-commit message is incorrect

nguyenminhchien · 2023-11-30T03:53:54Z

account_invoice_start_end_dates/views/account_move.xml

==> Tree view start_end_dates.view_move_line_tree at the line <field name="must_have_dates" invisible="1" />
replace invisible by column_invisible

nguyenminhchien · 2023-11-30T04:04:53Z

account_invoice_start_end_dates/models/account_move.py

@@ -20,9 +20,8 @@ def _post(self, soft=True):
                    raise UserError(
                        _(
                            "Missing Start Date and End Date for invoice "
-                            "line with Product '%s' which has the "
+                            "line with Product '{line.product_id.display_name}' which has the "


string parsing is incorrect:

replace "line with Product '{line.product_id.display_name}' which has the "
by f"line with Product '{line.product_id.display_name}' which has the "

are you sure about that? why not keeping the same translation string and use form _("", line.product_id.display_name)?

you're right, i made a mistake. @lethuthao2403 waits for me to have a look, will inform you then.

nguyenminhchien · 2023-11-30T04:06:24Z

account_invoice_start_end_dates/models/account_move_line.py

@@ -19,11 +19,11 @@ def _check_start_end_dates(self):
        for moveline in self:
            if moveline.start_date and not moveline.end_date:
                raise ValidationError(
-                    _("Missing End Date for line '%s'.") % (moveline.display_name)
+                    _("Missing End Date for line '{moveline.display_name}'.")


string parsing is incorrect

nguyenminhchien · 2023-11-30T04:06:27Z

account_invoice_start_end_dates/models/account_move_line.py

                )
            if moveline.end_date and not moveline.start_date:
                raise ValidationError(
-                    _("Missing Start Date for line '%s'.") % (moveline.display_name)
+                    _("Missing Start Date for line '{moveline.display_name}'.")


string parsing is incorrect

lethuthao2403 · 2023-11-30T05:05:15Z

@nguyenminhchien the PR has been updated. Thank you!

nguyenminhchien

I made a mistake about fstring, i add some suggestion, please update

nguyenminhchien · 2023-11-30T10:44:06Z

account_invoice_start_end_dates/models/account_move_line.py

+                )
+            if moveline.end_date and not moveline.start_date:
+                raise ValidationError(
+                    _(f"Missing Start Date for line '{moveline.display_name}'.")


Suggested change

_(f"Missing Start Date for line '{moveline.display_name}'.")

_("Missing Start Date for line '%s'.", moveline.display_name)

nguyenminhchien · 2023-11-30T10:44:28Z

account_invoice_start_end_dates/models/account_move_line.py

+        for moveline in self:
+            if moveline.start_date and not moveline.end_date:
+                raise ValidationError(
+                    _(f"Missing End Date for line '{moveline.display_name}'.")


Suggested change

_(f"Missing End Date for line '{moveline.display_name}'.")

_("Missing End Date for line '%s'.", moveline.display_name)

nguyenminhchien · 2023-11-30T10:46:35Z

account_invoice_start_end_dates/models/account_move.py

+                            "Missing Start Date and End Date for invoice "
+                            f"line with Product '{line.product_id.display_name}' which has the "
+                            "property 'Must Have Start/End Dates'."
+                        )


@lethuthao2403 please help to refactor:

raise UserError( _( "Missing Start Date and End Date for invoice " "line with Product '%s' which has the " "property 'Must Have Start/End Dates'.", line.product_id.display_name, ) )

lethuthao2403 · 2023-11-30T11:00:45Z

@nguyenminhchien the PR has been updated! Thank you.

alexis-via and others added 30 commits November 28, 2023 15:36

Port account_cutoff_base and account_cutoff_prepaid to Odoo v9

e8f828e

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Migration of account_cutoff modules to 10.0

782d7b4

account_invoice_start_end_dates: Migration to 11.0

8a3fe8f

Savepoint tests invoice_start

3572231

OCA Transbot updated translations from Transifex

439537b

README.rst

fc5b8b0

icon.png

08f98b6

README.rst

e6717ae

[MIG] account_invoice_start_end_dates to v13

e5341d7

Black

6321876

Use super() instead of super(classname, self)

f120952

[UPD] README.rst

9798fc8

Black and other pre-commit stuff

f7b55b3

FIX visibility of forecast button

defaa32

Default value for cutoff date is end date of previous fiscal year

[UPD] README.rst

c0ad412

[UPD] README.rst

c5e5c5c

[FIX] lint issues

70ad7f1

[MIG] account_invoice_start_end_dates from 13 to 14

500c89e

[UPD] README.rst

8df408c

account_invoice_start_end_dates 14.0.1.0.1

3c3978f

Added translation using Weblate (French (France))

d8e381c

[MIG] account_invoice_start_end_dates to v15

4ea0a2a

[UPD] README.rst

2f0567f

Alexis de Lattre and others added 12 commits November 28, 2023 15:41

cutoff modules: improve strings

b5f6c96

Remove deprecated POT files

[UPD] Update account_invoice_start_end_dates.pot

f97d0ff

account_invoice_start_end_dates 16.0.1.2.0

557ff03

Added translation using Weblate (Spanish)

06add89

[UPD] README.rst

006c99c

[TRN] remove fr_FR.po

02d6b9e

Co-authored-by: Alexis de Lattre <alexis@via.ecp.fr>

lethuthao2403 force-pushed the 17.0-mig-account_invoice_start_end_dates branch 5 times, most recently from 782cc5a to 52eedd7 Compare November 29, 2023 06:34

nguyenminhchien suggested changes Nov 30, 2023

View reviewed changes

[IMP] account_invoice_start_end_dates: pre-commit auto fixes

61e96b0

lethuthao2403 force-pushed the 17.0-mig-account_invoice_start_end_dates branch from 52eedd7 to 61885c8 Compare November 30, 2023 05:04

lethuthao2403 requested a review from nguyenminhchien November 30, 2023 05:05

nguyenminhchien approved these changes Nov 30, 2023

View reviewed changes

nguyenminhchien suggested changes Nov 30, 2023

View reviewed changes

lethuthao2403 force-pushed the 17.0-mig-account_invoice_start_end_dates branch from 61885c8 to 76f32b4 Compare November 30, 2023 11:00

lethuthao2403 force-pushed the 17.0-mig-account_invoice_start_end_dates branch 2 times, most recently from ead9c00 to f499d0e Compare December 5, 2023 08:12

[MIG] account_invoice_start_end_dates: Migration to 17.0

e075a60

lethuthao2403 force-pushed the 17.0-mig-account_invoice_start_end_dates branch from f499d0e to e075a60 Compare December 5, 2023 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_invoice_start_end_dates: Migration to 17.0 #4

[17.0][MIG] account_invoice_start_end_dates: Migration to 17.0 #4

lethuthao2403 commented Nov 28, 2023

nguyenminhchien left a comment

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023 •

edited

Loading

nilshamerlinck Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

lethuthao2403 commented Nov 30, 2023

nguyenminhchien left a comment

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

lethuthao2403 commented Nov 30, 2023

	_(f"Missing Start Date for line '{moveline.display_name}'.")
	_("Missing Start Date for line '%s'.", moveline.display_name)

	_(f"Missing End Date for line '{moveline.display_name}'.")
	_("Missing End Date for line '%s'.", moveline.display_name)

[17.0][MIG] account_invoice_start_end_dates: Migration to 17.0 #4

Are you sure you want to change the base?

[17.0][MIG] account_invoice_start_end_dates: Migration to 17.0 #4

Conversation

lethuthao2403 commented Nov 28, 2023

nguyenminhchien left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nguyenminhchien Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lethuthao2403 commented Nov 30, 2023

nguyenminhchien left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lethuthao2403 commented Nov 30, 2023

nguyenminhchien Nov 30, 2023 •

edited

Loading