Prevent unnecessary TeX block rerendering #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, a new decorated `TeXBlock` component was created on each call to the `blockRenderFn` which caused existing `TeXBlock` components to be unmounted an new ones mounted.
|
Awesome @letranloc, thanks a lot for publishing this plugin in the first place and also for pushing another release this quickly. Cheers 🙂 |
|
All PRs are welcome. Thanks! @pmeinhardt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, a new decorated
TeXBlockcomponent was created on each call to theblockRenderFnwhich caused existingTeXBlockcomponents to be unmounted and new ones mounted. That meant, that thecomponentWillReceivePropsoptimization in theKaTeXOutputcomponent wasn't effective.Since the props used for decorating do not change over time, we can instead only create the decorated
TexBlockcomponent once, when the plugin is configured.Before, we saw quite a bit of flickering when typing into an editor which was quite tiring.
Now it's completely smooth 😃
cc @tessi