Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and add tests #17

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Refactor and add tests #17

merged 3 commits into from
Jun 23, 2024

Conversation

interrrp
Copy link
Contributor

@interrrp interrrp commented Jun 16, 2024 •
edited
Loading

This pull request does a couple of things:

  • Add typings via JSDoc and enable type checking for JS files
  • Change function syntax to ES6 arrow functions
  • Change a lot of the code to use modern JS features
  • Add tests and use Jest for testing

shenanigansd
shenanigansd approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@shenanigansd shenanigansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, :shipit:

@shenanigansd shenanigansd merged commit 731d325 into letsbuilda:main Jun 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenanigansd shenanigansd shenanigansd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@interrrp @shenanigansd