Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the WFE and nonce-service configuration field NoncePrefixKey to utilize the new cmd.HMACKeyConfig type #7632

Open
beautifulentropy opened this issue Jul 25, 2024 · 0 comments · May be fixed by #7825
Open

Refactor the WFE and nonce-service configuration field NoncePrefixKey to utilize the new cmd.HMACKeyConfig type #7632

beautifulentropy opened this issue Jul 25, 2024 · 0 comments · May be fixed by #7825
Assignees
@jprenken
Labels
starter Ideal issues for folks getting familiar with Boulder
Milestone
Sprint 2024-11-05

Comments

@beautifulentropy
Copy link
Member

beautifulentropy commented Jul 25, 2024 •
edited
Loading

Since they use a different inner field name this is a two-part to maintain backwards compatibility.
@beautifulentropy beautifulentropy added the starter Ideal issues for folks getting familiar with Boulder label Jul 25, 2024
@beautifulentropy beautifulentropy changed the title Refactor WFE config field NoncePrefixKey to make use of the new cmd.HMACKeyConfig type Refactor the WFE and nonce-service configuration field NoncePrefixKey to utilize the updated cmd.HMACKeyConfig type Jul 25, 2024
@beautifulentropy beautifulentropy changed the title Refactor the WFE and nonce-service configuration field NoncePrefixKey to utilize the updated cmd.HMACKeyConfig type Refactor the WFE and nonce-service configuration field NoncePrefixKey to utilize the new cmd.HMACKeyConfig type Jul 25, 2024
@aarongable aarongable added this to the Sprint 2024-10-08 milestone Oct 8, 2024
@jprenken jprenken mentioned this issue Nov 8, 2024
Merged
beautifulentropy pushed a commit that referenced this issue Nov 13, 2024
@jprenken
WFE/nonce: Add NonceHMACKey field (#7793)
0a27cba 
Add a new WFE & nonce config field, `NonceHMACKey`, which uses the new
`cmd.HMACKeyConfig` type. Deprecate the `NoncePrefixKey` config field.

Generalize the error message when validating `HMACKeyConfig` in
`config`.

Remove the deprecated `UseDerivablePrefix` config field, which is no
longer used anywhere.

Part of #7632
jprenken added a commit that referenced this issue Nov 19, 2024
@jprenken
WFE/nonce: Remove deprecated NoncePrefixKey field
ff6c22d 
Remove the deprecated WFE & nonce config field `NoncePrefixKey`, which has been replaced by `NonceHMACKey`.

DO NOT MERGE until:
- #7793 (in `release-2024-11-18`) has been deployed, AND:
- `NoncePrefixKey` has been removed from all running configs.

Fixes #7632
@jprenken jprenken linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprenken jprenken

Labels
starter Ideal issues for folks getting familiar with Boulder
Projects
None yet
Milestone
Sprint 2024-11-05
Development

Successfully merging a pull request may close this issue.

WFE/nonce: Remove deprecated NoncePrefixKey field letsencrypt/boulder
3 participants
@aarongable @jprenken @beautifulentropy