fix: fix slice init length

[huochexizhan]

The intention here should be to initialize a slice with a capacity of len(nameToString) rather than initializing the length of this slice.

[aarongable]

Thanks, another good catch!

It looks like we use limitNames in three places, all of which are being formatted into error strings: once in parseOverrideNameID, once in loadAndParseOverrideLimits, and once in loadAndParseDefaultLimits.

These functions are tested (here, here, and here), but those tests didn't catch this bug in the error message. I suspect that's because those tests don't assert very much about the error itself, just that the function returns an error at all, and that the error isn't a failure to load the test file.

Can I ask you to add some additional asserts to each of these tests, to ensure that the right error is being encountered in each case? These would look something like

	// Burst cannot be 0.
	_, err = loadAndParseOverrideLimits("testdata/busted_override_burst_0.yml")
	test.AssertError(t, err, "single override limit with burst=0")
-	test.Assert(t, !os.IsNotExist(err), "test file should exist")
+ 	test.AssertContains(t, err.String(), "invalid burst")

Thanks!

[huochexizhan]

Thanks, another good catch!

It looks like we use limitNames in three places, all of which are being formatted into error strings: once in parseOverrideNameID, once in loadAndParseOverrideLimits, and once in loadAndParseDefaultLimits.

These functions are tested (here, here, and here), but those tests didn't catch this bug in the error message. I suspect that's because those tests don't assert very much about the error itself, just that the function returns an error at all, and that the error isn't a failure to load the test file.

Can I ask you to add some additional asserts to each of these tests, to ensure that the right error is being encountered in each case? These would look something like

	// Burst cannot be 0.
	_, err = loadAndParseOverrideLimits("testdata/busted_override_burst_0.yml")
	test.AssertError(t, err, "single override limit with burst=0")
-	test.Assert(t, !os.IsNotExist(err), "test file should exist")
+ 	test.AssertContains(t, err.String(), "invalid burst")

Thanks!

Thanks. Modified. Please review again.