Revert #263, fixes jsonSerialize fatal error on php 7.4 or lower #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://level-level.slack.com/archives/C02RENN0T/p1700146322403449
https://app.asana.com/0/1194139319537345/1205063740343242/f
Description
Reverts PR #263 .
This is needed because now already changing the return type would cause a fatal in PHP 7.4 or lower.
Instead, PR #265 has been created to bypass the deprication notice in PHP 8.1+, till Clarkson Core will not support PHP versions below 8.
How Has This Been Tested?
I picked a project running php 7.4.
And updated clarkson core in this project.
Then i added the following line to functions.php:
echo json_encode( post::get(1) );
. This breaks with the error shown in screenshot.Then I removed the mixed return type from the jsonSerialize function.
The error is now gone.
Screenshots (if appropriate):
Types of changes
Checklist: