Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/taxonomy typing #268

Closed
wants to merge 39 commits into from
Closed

Fix/taxonomy typing #268

wants to merge 39 commits into from

Conversation

Yorick-Level-Level
Copy link

Issue link

Description

The Clarkson term had a taxonomy that only allows null as value, now taxonomies can also hold strings.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

ken-ll and others added 30 commits February 16, 2021 16:34
@ken-ll
move twig instantiation to separate method
c09a813
@ken-ll
add template context
1f519b7
@ken-ll
remove lockfile
b679e41
@ken-ll
update dealerdirect/phpcodesniffer-composer-installer
7aa45bf
@ken-ll
psalm fix dates
b8c17ed
@ken-ll
composer fix
5b4d318
@ken-ll
move phpcodesniffer-composer-installer back to dev
4496c3d
@ken-ll
add baseline
263e0b1
@ken-ll
change php version for tests to 7.4
fcc1067
@ken-ll
move 7.4 in array
7b8e4bc
@ken-ll
remove quotes
e45ec15
@ken-ll
add realpath to clarkson_twig_template_dir filter
11b4ecb
@ken-ll
move template context up
9d33b9f
@ken-ll
add realpath option for non page templates
e8d205a
@ken-ll
composer fix
4dd2f12
@ken-ll
add pr template
24a3cb8
@ken-ll
Merge pull request #214 from level-level/0.4
c95d093 
0.4
@ken-ll
update readme for 0.4.4
97ddea5
@ken-ll
Merge pull request #215 from level-level/0.4-readme
5ebadfa 
update readme for 0.4.4
@ken-ll
use path if realpath is false
a7a86bf
@ken-ll
remove short ternary
5a780d1
@ken-ll
composer fix
b3d8e24
@ken-ll
add readme
91bbbee
@ken-ll
Merge pull request #216 from level-level/fix/realpath
2c344d9 
Fix/realpath
@ken-ll
set priority earlier
5546d5a
@ken-ll
Merge pull request #217 from level-level/fix/template-context-priority
f5ce3ad 
Change priority of clarkson_core_template_context filter
@ken-ll
update readme
e07242f
@ken-ll
Merge pull request #218 from level-level/update-readme-0.4
b3b9efd 
update readme
@ken-ll
make wakeup functions public
9184a22
@ken-ll
add phpcodesniffer to allow plugins
d766589
@Yorick-Level-Level Yorick-Level-Level self-assigned this Mar 28, 2024
@Yorick-Level-Level Yorick-Level-Level deleted the fix/taxonomy-typing branch March 28, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ken-ll ken-ll Awaiting requested review from ken-ll

Assignees

@Yorick-Level-Level Yorick-Level-Level

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yorick-Level-Level @ken-ll @NielsdeBlaauw @Jack-van-Bommel @Mike-Hermans