Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clarkson term taxonomy typing #269

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix clarkson term taxonomy typing #269

merged 3 commits into from
Mar 28, 2024

Conversation

Yorick-Level-Level
Copy link

Issue link

Description

Fixing the typing of taxonomy, now can hold strings aswel.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Yorick-Level-Level Yorick-Level-Level self-assigned this Mar 28, 2024
@NielsdeBlaauw NielsdeBlaauw merged commit 98fe894 into 0.4-lts Mar 28, 2024
1 check passed
@NielsdeBlaauw NielsdeBlaauw deleted the fix/clarkson-term-taxonomy branch March 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NielsdeBlaauw NielsdeBlaauw NielsdeBlaauw approved these changes

@ken-ll ken-ll ken-ll approved these changes

Assignees

@Yorick-Level-Level Yorick-Level-Level

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yorick-Level-Level @NielsdeBlaauw @ken-ll