Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/extend compatibility by using composite #48

Merged
merged 11 commits into from
Sep 11, 2021
Merged

Feature/extend compatibility by using composite #48

merged 11 commits into from
Sep 11, 2021

Conversation

matiasalbarello
Copy link
Contributor

@matiasalbarello matiasalbarello commented Sep 11, 2021 •
edited
Loading

With this changes, we should be able to extend compatibility to (at least) MacOS hosted runners.

  • Add test workflow running on MacOS
  • Test if it works on Windows

@matiasalbarello matiasalbarello self-assigned this Sep 11, 2021
@matiasalbarello matiasalbarello marked this pull request as ready for review September 11, 2021 07:41
@progapandist
Copy link
Collaborator

Interesting! I'd make sure it really works across platforms first with the windows and macOS suite before merging.

@matiasalbarello matiasalbarello merged commit 7e01e45 into master Sep 11, 2021
@matiasalbarello matiasalbarello deleted the feature/extend-compatibility-by-using-composite branch September 11, 2021 20:16
@matiasalbarello matiasalbarello mentioned this pull request Sep 11, 2021
Closed
matiasalbarello added a commit that referenced this pull request Sep 12, 2021
@matiasalbarello
Revert "Merge pull request #48 from lewagon/feature/extend-compatibil…
d4995b6 
…ity-by-using-composite"

This reverts commit 7e01e45, reversing
changes made to 5e93735.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progapandist progapandist Awaiting requested review from progapandist

Assignees

@matiasalbarello matiasalbarello

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasalbarello @progapandist