Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octokit client: don't authenticate with empty string #67

Merged
merged 6 commits into from
Jul 3, 2022

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jun 9, 2022

Fixes an issue where you get authentication errors when not specifying an access token to access public data since v1.0.0. Issue I opened here: #66

Feel free to push updates to my branch if there's a better way to do this, just learning Ruby!

@sshane sshane changed the title Don't authenticate with empty string Octokit client: don't authenticate with empty string Jun 9, 2022
@matiasalbarello
Copy link
Contributor

Hi @sshane. Thanks for the PR! It looks good to me. Could you add a simple workflow test? (You can take the one I created here)

@matiasalbarello
Copy link
Contributor

You should be able to do a simple cherry-pick:
git cherry-pick 6395ec5e4e70d1a7ec9e3e7a4be4be154b4f8397

@sshane
Copy link
Contributor Author

sshane commented Jun 29, 2022

How does that look?

@matiasalbarello matiasalbarello merged commit e255823 into lewagon:master Jul 3, 2022
@sshane sshane deleted the no-auth branch July 12, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants