Feature/change login to use password stdin, fixing issue #17 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers' into feature/Configure-squash-and-layers # Conflicts: # CHANGELOG.md # pom.xml # src/main/java/nl/lexemmens/podman/image/BuildImageConfiguration.java # src/main/java/nl/lexemmens/podman/service/PodmanExecutorService.java # src/test/java/nl/lexemmens/podman/service/PodmanExecutorServiceTest.java
… and podman executor services and extended it with fluend command configuration. Refactored podman login command to use --password-stdin instead of commandline provided password, fixing issue lexemmens#17
|
I will take a look at the outstanding task next week. Finally got my development environment back up and running - will be a packed release 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted common AbstractExecutorService as new base for both buildah and podman executor services and extended it with fluent command configuration.
Refactored podman login command to use --password-stdin instead of commandline provided password, fixing issue #17
Rebased on feature/Configure-squash-and-layers