Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dump state before stop rule #3468

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 24, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (705cac1) to head (f13fccb).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/checkpoint/coordinator.go 80.36% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3468      +/-   ##
==========================================
+ Coverage   71.39%   71.43%   +0.04%     
==========================================
  Files         414      415       +1     
  Lines       47606    47668      +62     
==========================================
+ Hits        33985    34049      +64     
- Misses      10967    10969       +2     
+ Partials     2654     2650       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review December 26, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant