Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(io): merge dirwatch into file source #3480

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
merge into file source

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review December 26, 2024 07:05
@ngjaying ngjaying requested a review from Yisaer December 26, 2024 07:05
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 51.56250% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.32%. Comparing base (2f89c46) to head (6d8c723).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/file/source.go 50.79% 27 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3480      +/-   ##
==========================================
- Coverage   71.36%   71.32%   -0.05%     
==========================================
  Files         415      414       -1     
  Lines       47814    47707     -107     
==========================================
- Hits        34122    34023      -99     
+ Misses      11027    11021       -6     
+ Partials     2665     2663       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant