Skip to content

Commit

Permalink
proto: enhance ntp configuration
Browse files Browse the repository at this point in the history
1. allow to set more than one NTP server
2. allow to make NTP servers from cloud controller exclusively used,
   i.e. the NTP servers that got announced via DHCP are not used
   (in certain cases this an attacker might send DHCP responses with
    a different NTP server set and therefore can control time on EVE)

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
  • Loading branch information
christoph-zededa committed Oct 11, 2024
1 parent 60db108 commit 57101ef
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
8 changes: 8 additions & 0 deletions proto/config/devconfig.proto
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,14 @@ message EdgeDevConfig {

// cluster configuration
EdgeNodeCluster cluster = 43;
DhcpVendorExtensionsOverride dhcp_extensions_override = 44;
}

// DhcpVendorExtensionsOverride is used to override or add dhcp vendor extensions like f.e.
// the NTP servers - currently no other options are supported, but DNS servers might be a
// good candidate in the future
message DhcpVendorExtensionsOverride {
bool ntpServerExclusively = 1; // use exclusively specified NTP servers

Check failure on line 179 in proto/config/devconfig.proto

View workflow job for this annotation

GitHub Actions / yetus

buflint:Field name "ntpServerExclusively" should be lower_snake_case, such as "ntp_server_exclusively".
}

message ConfigRequest {
Expand Down
1 change: 1 addition & 0 deletions proto/info/info.proto
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,7 @@ message DevicePort {
// domainname - OBSOLETE - obsoleted by dns
string domainname = 14;
string ntpServer = 15;
repeated string extraNtpServers = 35;

Check failure on line 770 in proto/info/info.proto

View workflow job for this annotation

GitHub Actions / yetus

buflint:Field name "extraNtpServers" should be lower_snake_case, such as "extra_ntp_servers".
// dnsServers - OBSOLETE - obsoleted by dns
repeated string dnsServers = 16;
string dhcpRangeLow = 17;
Expand Down

0 comments on commit 57101ef

Please sign in to comment.