Skip to content

Commit

Permalink
EVE AppInst Discovery: move allow_to_discover to AppInst port
Browse files Browse the repository at this point in the history
This is more granular approach. From appInstance perspective,
you also know which network port will be used.

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
  • Loading branch information
uncleDecart committed Apr 17, 2024
1 parent 6fe2bd3 commit d255c3e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 3 additions & 4 deletions proto/config/appconfig.proto
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ message SnapshotConfig {
// can also be increased to cause an application instance restart without
// any other change to the application instance.
message AppInstanceConfig {
// deprecated fields
reserved 14, 24;

UUIDandVersion uuidandversion = 1;
string displayname = 2; // User-friendly name
VmConfig fixedresources = 3;
Expand Down Expand Up @@ -206,10 +209,6 @@ message AppInstanceConfig {

// PatchEnvelopeRef is used to track all patch envelopes used by the app instance
PatchEnvelopeRef patchRef = 23;

// allow AppInstance to discover other AppInstances
// attached to its network instances
bool allow_to_discover = 24;
}

message PatchEnvelopeRef {
Expand Down
4 changes: 4 additions & 0 deletions proto/config/netconfig.proto
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ message NetworkAdapter {
// valid vlan id range: 2 - 4093
// vlan id 1 is implicitly used by linux bridges
uint32 access_vlan_id = 41;

// allow AppInstance to discover other AppInstances
// attached to this network instance. Default is false
bool allow_to_discover = 42;
}

message WirelessConfig {
Expand Down

0 comments on commit d255c3e

Please sign in to comment.