Improve workflows #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eriknordmark <erik@zededa.com>
Signed-off-by: eriknordmark <erik@zededa.com>
Yes, it is a frustration of mine. I have reached out to the maintainers, but have not heard back. I dug into how the images are generated, and it is fixable, but we are blocked until they respond. I will ping them again. I kept the image check under the assumption that we would fix it quickly, and thus better to be sure it was changed. Clearly, it is not happening quickly, so your approach is better. |
deitch
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the diff check in ci.yaml is using a constant and not a variable. Fixes issue #20
And we want to exclude the images from the comparison since the buider produces different output each time it is run with identical source files.
Second commit was just checking yamllint and discovering that the indentation etc is off for yetus.yaml.