Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report SIM card type #51

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Report SIM card type #51

merged 2 commits into from
Apr 5, 2024

Conversation

milan-zededa
Copy link
Contributor

@milan-zededa milan-zededa commented Apr 4, 2024

This will allow to distinguish between a physical SIM card and an eSIM.
Older EVE versions will report the SIM card type as UNSPECIFIED.

Note that we will get this info from ModemManager:
https://www.freedesktop.org/software/ModemManager/doc/latest/ModemManager/ModemManager-Flags-and-Enumerations.html#MMSimType

This will allow to distinguish between a physical SIM card and
an eSIM.
Older EVE versions will report the SIM card type as UNSPECIFIED.

Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
Copy link
Member

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 57b8263 into lf-edge:main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants