-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubeClusterMetrics: node and app cpu/mem usage. #72
Conversation
eaef607
to
4cbe160
Compare
proto/metrics/metrics.proto
Outdated
} | ||
|
||
// Resources used as reported by kubernetes api for pods running eve user apps. | ||
message KubeEVEAppPodMetrics { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only pod metrics ? What about the VMI ? Do we still use pod metrics for VMI too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each vmi app has an associated pod (virt-launcher-*), vmi and vmirs objects in the eve-kube-app namespace.
The vmi lists cpu cores, memory Gi resources, and storage bytes requested.
The vmirs list cpu cores and memory Gi resources.
The virt-launcher pod lists two containers virt-launcher-monitor (the vm) and virt-tail (logs). Neither of these specifically list cores but instead a Millicore value which doesn't seem to match the core count. My virt-launcher reports 200millicores which is 1/5th of a core instead of the vmi and vmirs which report 2 cores. Using memory requests from the virt-launcher pod does seem to be the most complete view of all memory used by all containers associated with a running domain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zedi-pramodh I've changed KubeEVEAppPodMetrics to a generically named KubeEVEAppMetrics and KubeClusterMetrics now has two lists of it eve_pod_apps and eve_vmi_apps. How does this look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zedi-pramodh I've changed KubeEVEAppPodMetrics to a generically named KubeEVEAppMetrics and KubeClusterMetrics now has two lists of it eve_pod_apps and eve_vmi_apps. How does this look?
That sounds right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that causes a change in controller API. Just cross check with @xyuria-zededa
4cbe160
to
809c11d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not holding it up for the naming question, so approved, but if you agree on it, would be good to change.
For kubevirt-eve images this adds per node and eve-user-app cpu/memory usage metrics. Fix: add cluster_id to ZInfoKubeClusterUpdateStatus Signed-off-by: Andrew Durbin <andrewd@zededa.com>
Signed-off-by: Andrew Durbin <andrewd@zededa.com>
809c11d
to
d6f209b
Compare
For kubevirt-eve images this adds per node and eve-user-app cpu/memory usage metrics.
Fix: add cluster_id to ZInfoKubeClusterUpdateStatus