Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need for derived tags when building ephemeral images in CI #5

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Aug 18, 2024

We were building in prbuild.yaml with the following tags:

              ${{ github.event.pull_request.head.repo.full_name }}:${{ github.event.pull_request.head.ref }}
              ${{ github.event.pull_request.head.repo.full_name }}:latest

These builds all get thrown away, for testing only. As long as the ref of the PR head is a valid tag, it worked. But if it isn't - and that can happen often - it failed. Since these are just getting thrown away, leave it as latest only.

In main build we use the actual commit, which always is a valid tag. And in release, we use semver. So those are fine.

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch merged commit 877f7cc into main Aug 18, 2024
1 check passed
@deitch deitch deleted the ci-tags branch August 18, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant