Streamline unit-tests that use a TPM

[shjala]

1. Create all the required keys for the TPM tests in the prep-and-test.sh before running the tests. This changes adds the creation of AIK key and also changes other keys creation method to creates all keys under Owner hierarchy rather than EK, just like we do in EVE.
2. Add helper functions for simulate TPM.
3. Streamline all the unit-tests that uses TPM, by removing the duplicated code and making all to use the sim tpm helper functions.

[OhmSpectator]

Sorry =D

[OhmSpectator]

In general, it would be nice to run the test in a container so that it can be used on any system. However, the preparation script currently works only on Ubuntu-based systems. But it's out of scope of the PR.

[OhmSpectator]

Looks good. I realized too late that it was basically about just moving functions to shared files =D

[OhmSpectator]

Another question of curiosity. In the commit message, you say:

This changes adds the creation of AIK key and
also changes other keys creation method to creates all keys under Owner
hirearchy rather than EK, just like we do in EVE.

Can you please point me to where it is done in EVE?

[shjala]

Here :

eve/pkg/pillar/cmd/tpmmgr/tpmmgr.go

Lines 717 to 734 in 9a29580

	func createOtherKeys(override bool) error {
	if err := etpm.CreateKey(log, etpm.TpmDevicePath, etpm.TpmEKHdl, tpm2.HandleEndorsement, etpm.DefaultEkTemplate, override); err != nil {
	return fmt.Errorf("error in creating Endorsement key: %w ", err)
	}
	if err := etpm.CreateKey(log, etpm.TpmDevicePath, etpm.TpmSRKHdl, tpm2.HandleOwner, etpm.DefaultSrkTemplate, override); err != nil {
	return fmt.Errorf("error in creating SRK key: %w ", err)
	}
	if err := etpm.CreateKey(log, etpm.TpmDevicePath, etpm.TpmAIKHdl, tpm2.HandleOwner, etpm.DefaultAikTemplate, override); err != nil {
	return fmt.Errorf("error in creating Attestation key: %w ", err)
	}
	if err := etpm.CreateKey(log, etpm.TpmDevicePath, etpm.TpmQuoteKeyHdl, tpm2.HandleOwner, etpm.DefaultQuoteKeyTemplate, override); err != nil {
	return fmt.Errorf("error in creating Quote key: %w ", err)
	}
	if err := etpm.CreateKey(log, etpm.TpmDevicePath, etpm.TpmEcdhKeyHdl, tpm2.HandleOwner, etpm.DefaultEcdhKeyTemplate, override); err != nil {
	return fmt.Errorf("error in creating ECDH key: %w ", err)
	}
	return nil
	}

btw, the ownerHandle in CreateKey is unused so don't and we don't create the EK under tpm2.HandleEndorsement, and tpm2.HandleOwner is hardcoded in the function. I want to clean that up for ages :D

[OhmSpectator]

Thanks!
It may make sense to add a comment to the prep script that it refers to this code (and vice versa), especially if you have a plan to change it.

[shjala]

sure.

[OhmSpectator]

@shjala

[yetus: pkg/pillar/cmd/tpmmgr/tpmmgr.go#L717](https://github.com/lf-edge/eve/pull/4239/files#annotation_26226706455)
codespell: hirarchy ==> hierarchy

The very last thing)

[shjala]

SPDX check glitching.

[OhmSpectator]

SPDX check glitching.

Yep... I also don't understand how it happened.
I guess it's just because the branch is not rebased on the latest master state.