Include uboot bits in installer image #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They already are added to the installer ESP, but the installer itself did not have access to them, and thus would not install them on the target disk. Signed-off-by: Avi Deitcher <avi@deitcher.net>
| @@ -29,6 +30,9 @@ volumes: | |||
| - name: mkimage-raw-efi | |||
| image: MKRAW_TAG | |||
| readonly: true | |||
| - name: uboot | |||
There was a problem hiding this comment.
Isn't it ARM specific? Shouldn't we add it conditionally somehow?
There was a problem hiding this comment.
Nah, it is available for all platforms, even riscv64. Different content. It works on all of them.
There was a problem hiding this comment.
Strange... Why do we need u-boot for x86, for example... But ok, let it be...
|
pull rate limits... |
OhmSpectator
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4288
They already are added to the installer ESP, but the installer itself did not have access to them, and thus would not install them on the target disk.
The source is
pkg/u-boot.This PR adds the contents of that pkg to
installer.ymlas a volume, and then mounts it into the installer container, which makes it available tomake-rawas/parts/boot, which then knows what to do with.There is a bit of duplication here, but this is cleaner than alternatives.
At some point we should eliminate the
installer/bootdirectory and make it all use what is in theinstaller.tar. That needs some changes torootfs.tar, which would be beyond scope of this PR.cc @rene