fix: web wallet connection

[irisdv]

Summary by CodeRabbit

• Chores
  • Updated dependency versions for improved performance and stability:
    • @starknet-react/core from ^3.0.0 to ^3.0.1
    • starknetkit from ^2.3.0 to ^2.3.2

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 7, 2024 0:49am
sepolia-app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 7, 2024 0:49am

[coderabbitai]

Walkthrough

The package.json file for the starknet-id-app project has been modified to update the versions of two dependencies. The version of @starknet-react/core has been changed from ^3.0.0 to ^3.0.1, and the version of starknetkit has been updated from ^2.3.0 to ^2.3.2. No other changes have been made to dependencies or scripts.

Changes

File	Change Summary
package.json	Updated @starknet-react/core from ^3.0.0 to ^3.0.1 and starknetkit from ^2.3.0 to ^2.3.2.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 401ed85 and 842334d.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

• package.json (2 hunks)

🧰 Additional context used

🔇 Additional comments (3)

package.json (3)

26-26: Ensure thorough testing of wallet connections

The updates to @starknet-react/core and starknetkit are likely aimed at fixing web wallet connection issues as mentioned in the PR title. Please ensure that comprehensive testing has been performed to verify that these updates resolve the intended issues and don't introduce any new problems.

To assist with testing, consider running the following commands in your development environment:

Also applies to: 50-50

---

26-26: Verify the impact of @starknet-react/core update

The @starknet-react/core package has been updated from ^3.0.0 to ^3.0.1. This minor version update likely includes bug fixes and improvements related to web wallet connections.

Let's verify if this is the latest version and check for any breaking changes:

✅ Verification successful

@starknet-react/core is up-to-date and no issues found

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check the latest version of @starknet-react/core
npm view @starknet-react/core version

# Check for any breaking changes or important notes in the changelog
curl -s https://raw.githubusercontent.com/apibara/starknet-react/main/CHANGELOG.md | head -n 20

Length of output: 304

---

Script:

#!/bin/bash
# Extract the current version of @starknet-react/core from package.json
grep '"@starknet-react/core"' package.json | awk -F '"' '{print $4}'

# Check the latest version available on npm registry without using npm
curl -s https://registry.npmjs.org/@starknet-react/core | grep '"latest":' | awk -F '"' '{print $4}'

# Fetch the changelog from the correct GitHub repository
curl -s https://raw.githubusercontent.com/starknet-react/starknet-react/main/CHANGELOG.md | head -n 20

Length of output: 321

---

Script:

#!/bin/bash
# Extract the current version of @starknet-react/core from package.json
grep '"@starknet-react/core"' package.json | awk -F '"' '{print $4}'

# Check the latest version available on npm registry without using npm
curl -s https://registry.npmjs.org/@starknet-react/core | grep '"latest":' | sed -E 's/.*"latest": *"([^"]+)".*/\1/'

# Attempt to locate the CHANGELOG.md in the correct GitHub repository
# First, find the repository URL from package.json or npm registry
curl -s https://registry.npmjs.org/@starknet-react/core | grep '"repository":' -A 2 | grep '"url":' | sed -E 's/.*"url": *"([^"]+)".*/\1/' | sed 's/^git+//;s/.git$//' > repo_url.txt

# Read the repository URL
REPO_URL=$(cat repo_url.txt)

# Fetch the changelog from the detected repository
if [ -n "$REPO_URL" ]; then
    curl -s "${REPO_URL}/blob/main/CHANGELOG.md" | head -n 20
else
    echo "Repository URL not found."
fi

Length of output: 886

---

Script:

#!/bin/bash
# Search for CHANGELOG.md in the repository
fd "CHANGELOG.md" > changelog_paths.txt

# Check if any changelog files were found
if [ -s changelog_paths.txt ]; then
    echo "Found the following CHANGELOG.md files:"
    cat changelog_paths.txt
    echo ""
    # Display the first 20 lines of each found changelog
    while read -r changelog; do
        echo "Contents of $changelog:"
        head -n 20 "$changelog"
        echo ""
    done < changelog_paths.txt
else
    echo "No CHANGELOG.md file found in the repository."
fi

Length of output: 151

---

50-50: Verify the impact of starknetkit update

The starknetkit package has been updated from ^2.3.0 to ^2.3.2. This patch version update likely includes bug fixes related to web wallet connections.

Let's verify if this is the latest version and check for any breaking changes:

✅ Verification successful

starknetkit update to v2.3.2 is appropriate and safe

The update of starknetkit from v2.3.0 to v2.3.2 is a minor patch that adds parameters to the connect method and updates the starknetkit modal to use silent mode. This change enhances functionality without introducing breaking changes. The current version specification in package.json (^2.3.2) is correct and allows for compatible updates within the 2.3.x range.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check the latest version of starknetkit
npm view starknetkit version

# Check for any breaking changes or important notes in the changelog
curl -s https://raw.githubusercontent.com/starknet-io/starknetkit/main/CHANGELOG.md | head -n 20

Length of output: 304

---

Script:

#!/bin/bash
# Fetch the latest version of starknetkit from the npm registry
curl -s https://registry.npmjs.org/starknetkit | jq -r '.["dist-tags"].latest'

# Retrieve the latest 20 lines of the changelog from the correct repository
# First, find the repository URL from package.json
REPO_URL=$(grep -m 1 '"repository"' package.json | grep -o 'https://[^"]*')
# Modify the URL to point to the CHANGELOG.md in the main branch
CHANGELOG_URL="${REPO_URL%.git}/raw/main/CHANGELOG.md"
# Fetch the first 20 lines of the changelog
curl -s "$CHANGELOG_URL" | head -n 20

Length of output: 251

---

Script:

#!/bin/bash
# Fetch the latest version of starknetkit from the npm registry
LATEST_VERSION=$(curl -s https://registry.npmjs.org/starknetkit | jq -r '.["dist-tags"].latest')
echo "Latest version of starknetkit: $LATEST_VERSION"

# Fetch the repository URL from the npm registry
REPO_URL=$(curl -s https://registry.npmjs.org/starknetkit | jq -r '.repository.url' | sed 's/^git+//;s/.git$//')
echo "Repository URL: $REPO_URL"

# Construct the CHANGELOG.md URL
CHANGELOG_URL="${REPO_URL}/raw/main/CHANGELOG.md"

# Attempt to fetch the first 20 lines of the changelog
CHANGES=$(curl -s "$CHANGELOG_URL" | head -n 20)

# Check if changelog was retrieved successfully
if [[ -z "$CHANGES" ]]; then
  echo "Failed to retrieve CHANGELOG.md from $CHANGELOG_URL"
else
  echo "$CHANGES"
fi

Length of output: 1603

---

Script:

#!/bin/bash
# Fetch the latest releases of starknetkit from the GitHub API
RELEASES=$(curl -s https://api.github.com/repos/argentlabs/starknetkit/releases)

# Check if the releases were fetched successfully
if [[ -z "$RELEASES" ]]; then
  echo "Failed to fetch releases from the GitHub API."
  exit 1
fi

# Extract the latest release tag
LATEST_RELEASE_TAG=$(echo "$RELEASES" | jq -r '.[0].tag_name')
echo "Latest release tag: $LATEST_RELEASE_TAG"

# Extract the release notes/body
RELEASE_NOTES=$(echo "$RELEASES" | jq -r '.[0].body')
if [[ -z "$RELEASE_NOTES" ]]; then
  echo "No release notes found for the latest release."
else
  echo "Release notes for $LATEST_RELEASE_TAG:"
  echo "$RELEASE_NOTES" | head -n 20
fi

Length of output: 272524

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fricoben]

lgtm