Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update full journal and account journal after adding new booking entry #21

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

lg2de
Copy link
Owner

@lg2de lg2de commented Feb 22, 2020

Description

  • ensure new grid items visible
  • update account journal after changing account
  • code cleanup

Related issue

Fixes #19

* ensure new grid items visible
* update account journal after changing account
* code cleanup
@lg2de lg2de changed the title update full journal and account journal after add new booking entry update full journal and account journal after adding new booking entry Feb 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #21 into master will increase coverage by 0.39%.
The diff coverage is 75.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   62.44%   62.84%   +0.39%     
==========================================
  Files          28       29       +1     
  Lines        2748     2772      +24     
  Branches      364      366       +2     
==========================================
+ Hits         1716     1742      +26     
- Misses        955      956       +1     
+ Partials       77       74       -3
Impacted Files Coverage Δ
src/SimpleAccounting/Presentation/ShellView.xaml 0% <0%> (ø)
...pleAccounting/Presentation/ShellDesignViewModel.cs 100% <100%> (ø) ⬆️
...pleAccounting/Presentation/FullJournalViewModel.cs 100% <100%> (ø)
...rc/SimpleAccounting/Presentation/ShellViewModel.cs 82.3% <75.65%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ccdbe1...37b9ed9. Read the comment docs.

@lg2de lg2de merged commit e72c54a into master Feb 22, 2020
@lg2de lg2de deleted the EnsureVisible branch February 22, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure visible new booking entry
2 participants