Adjust to changes (thofma#1612)

lgoettgens · Sep 19, 2024 · 3ba1417 · 3ba1417
1 parent d256f3a
commit 3ba1417
Show file tree

Hide file tree

Showing 30 changed files with 66 additions and 190 deletions.
diff --git a/examples/Round2.jl b/examples/Round2.jl
@@ -175,11 +175,6 @@ function Hecke.add!(a::OrderElem, b::OrderElem, c::OrderElem)
   return a
 end
 
-function Hecke.addeq!(a::OrderElem, b::OrderElem)
-  a.data = Hecke.addeq!(a.data, b.data)
-  return a
-end
-
 function Hecke.tr(a::OrderElem)
   return parent(a).R(trace(a.data))
 end
@@ -936,16 +931,6 @@ function Hecke.add!(a::HessQRElem, b::HessQRElem, c::HessQRElem)
   return a
 end
 
-function Hecke.addeq!(a::HessQRElem, b::HessQRElem)
-  d = a+b
-  @assert parent(a.f) == parent(d.f)
-  @assert parent(a.g) == parent(d.g)
-  a.c = d.c
-  a.f = d.f
-  a.g = d.g
-  return a
-end
-
 function divrem(a::HessQRElem, b::HessQRElem)
   check_parent(a, b)
   if iszero(b)

diff --git a/examples/Suri.jl b/examples/Suri.jl
@@ -1,6 +1,6 @@
 module Suri
 using Hecke
-import Hecke: valuation, divexact, parent_type, elem_type, mul!, addeq!, parent
+import Hecke: valuation, divexact, parent_type, elem_type, mul!, add!, parent
 import Base: +, -, *, ^
 
 #= follows Sebastian Posur's idea
@@ -293,7 +293,7 @@ divexact(a::RRSelem, b::RRSelem; check::Bool=true) = RRSelem(a.R, [mod(a.x[i]*in
 (R::RRS)(a::Integer) = RRSelem(R, a)
 (R::RRS)(a::RRSelem) = a
 
-function addeq!(a::RRSelem, b::RRSelem)
+function add!(a::RRSelem, b::RRSelem)
   for i=1:length(a.x)
     a.x[i] = mod(a.x[i] + b.x[i], a.R.p[i])
     a.r    = mod(a.r    + b.r   , a.R.r)

diff --git a/ext/GAPExt/fields.jl b/ext/GAPExt/fields.jl
@@ -146,10 +146,10 @@ function Base.push!(G::AbstractAlgebra.Generic.geobucket{T}, p::T) where {T <: A
        G.buckets[j] = zero(R)
      end
    end
-   G.buckets[i] = addeq!(G.buckets[i], p)
+   G.buckets[i] = add!(G.buckets[i], p)
    while i <= G.len
       if length(G.buckets[i]) >= 4^i
-         G.buckets[i + 1] = addeq!(G.buckets[i + 1], G.buckets[i])
+         G.buckets[i + 1] = add!(G.buckets[i + 1], G.buckets[i])
          G.buckets[i] = R()
          i += 1
       end

diff --git a/src/AlgAss/AbsAlgAss.jl b/src/AlgAss/AbsAlgAss.jl
@@ -18,7 +18,7 @@ base_ring(A::AbstractAssociativeAlgebra)
 
 Return the zero ring as an algebra over the field $K$.
 
-The optional first argument determines the type of the algebra, and can be 
+The optional first argument determines the type of the algebra, and can be
 `StructureConstantAlgebra` (default) or `MatrixAlgebra`.
 
 # Examples
@@ -354,7 +354,7 @@ function _add_row_to_rref!(M::MatElem{T}, v::Vector{T}, pivot_rows::Vector{Int},
       end
 
       s = mul!(s, t, Mrj)
-      v[j] = addeq!(v[j], s)
+      v[j] = add!(v[j], s)
     end
     v[c] = zero!(v[c])
   end
@@ -383,7 +383,7 @@ function _add_row_to_rref!(M::MatElem{T}, v::Vector{T}, pivot_rows::Vector{Int},
     t = -Mrp
     for c = pivot_col + 1:ncols(M)
       s = mul!(s, t, v[c])
-      M[r, c] = addeq!(M[r, c], s)
+      M[r, c] = add!(M[r, c], s)
     end
     M[r, pivot_col] = zero(base_ring(M))
   end

diff --git a/src/AlgAss/AlgMatElem.jl b/src/AlgAss/AlgMatElem.jl
@@ -143,16 +143,6 @@ function mul!(c::T, a::T, b::T) where {T <: MatAlgebraElem}
   return c
 end
 
-function addeq!(b::T, a::T) where {T <: MatAlgebraElem}
-  parent(a) != parent(b) && error("Parents don't match.")
-  A = parent(a)
-
-  b.matrix = addeq!(b.matrix, a.matrix)
-  b.has_coeffs = false
-
-  return b
-end
-
 function mul!(c::MatAlgebraElem{T}, a::MatAlgebraElem{T}, b::T) where {T}
   parent(c) !== parent(a) && error("Parents don't match.")
   A = parent(a)

diff --git a/src/AlgAss/Elem.jl b/src/AlgAss/Elem.jl
@@ -260,17 +260,6 @@ function add!(c::AbstractAssociativeAlgebraElem{T}, a::AbstractAssociativeAlgebr
   return c
 end
 
-function addeq!(b::AbstractAssociativeAlgebraElem{T}, a::AbstractAssociativeAlgebraElem{T}) where {T}
-  parent(a) != parent(b) && error("Parents don't match.")
-  A = parent(a)
-
-  for i = 1:dim(A)
-    b.coeffs[i] = addeq!(coefficients(b, copy = false)[i], coefficients(a, copy = false)[i])
-  end
-
-  return b
-end
-
 function mul!(c::AbstractAssociativeAlgebraElem{T}, a::AbstractAssociativeAlgebraElem{T}, b::T) where {T}
   parent(a) != parent(c) && error("Parents don't match.")
 

diff --git a/src/AlgAssAbsOrd/Elem.jl b/src/AlgAssAbsOrd/Elem.jl
@@ -303,12 +303,6 @@ end
 #
 ################################################################################
 
-function addeq!(x::T, y::T) where { T <: Union{ AlgAssAbsOrdElem, AlgAssRelOrdElem } }
-  x.elem_in_algebra = addeq!(elem_in_algebra(x, copy = false), elem_in_algebra(y, copy = false))
-  x.has_coord = false
-  return x
-end
-
 function add!(z::T, x::T, y::T) where { T <: Union{ AlgAssAbsOrdElem, AlgAssRelOrdElem } }
   z.elem_in_algebra = add!(elem_in_algebra(z, copy = false), elem_in_algebra(x, copy = false), elem_in_algebra(y, copy = false))
   z.has_coord = false

diff --git a/src/AlgAssAbsOrd/PicardGroup.jl b/src/AlgAssAbsOrd/PicardGroup.jl
@@ -275,7 +275,7 @@ function _picard_group_non_maximal(O::AlgAssAbsOrd, prepare_ref_disc_log::Bool =
         end
 
         Q[i, j] = div(-C[i, j], R.snf[j]) + 1
-        C[i, j] = addeq!(C[i, j], R.snf[j]*Q[i, j])
+        C[i, j] = add!(C[i, j], R.snf[j]*Q[i, j])
       end
     end
 

diff --git a/src/FunField/DegreeLocalization.jl b/src/FunField/DegreeLocalization.jl
@@ -156,10 +156,6 @@ function mul!(a::KInftyElem{T}, b::KInftyElem{T}, c::KInftyElem{T}) where {T}
   return b*c
 end
 
-function addeq!(a::KInftyElem{T}, b::KInftyElem{T}) where {T}
-  return a+b
-end
-
 ###############################################################################
 #
 #   Comparison

diff --git a/src/FunField/HessQR.jl b/src/FunField/HessQR.jl
@@ -198,16 +198,6 @@ function Hecke.add!(a::HessQRElem, b::HessQRElem, c::HessQRElem)
   return a
 end
 
-function Hecke.addeq!(a::HessQRElem, b::HessQRElem)
-  d = a+b
-  @assert parent(a.f) == parent(d.f)
-  @assert parent(a.g) == parent(d.g)
-  a.c = d.c
-  a.f = d.f
-  a.g = d.g
-  return a
-end
-
 function divrem(a::HessQRElem, b::HessQRElem)
   check_parent(a, b)
   if iszero(b)

diff --git a/src/GenOrd/GenOrd.jl b/src/GenOrd/GenOrd.jl
@@ -300,11 +300,6 @@ function add!(a::GenOrdElem, b::GenOrdElem, c::GenOrdElem)
   return a
 end
 
-function addeq!(a::GenOrdElem, b::GenOrdElem)
-  a.data = Hecke.addeq!(a.data, b.data)
-  return a
-end
-
 ################################################################################
 #
 #  Trace and norm

diff --git a/src/LocalField/Elem.jl b/src/LocalField/Elem.jl
@@ -617,13 +617,6 @@ function add!(c::LocalFieldElem{S, T}, a::LocalFieldElem{S, T}, b::LocalFieldEle
   return c
 end
 
-function addeq!(c::LocalFieldElem{S, T}, a::LocalFieldElem{S, T}) where {S <: FieldElem, T <: LocalFieldParameter}
-  check_parent(a, c)
-  c.data = add!(c.data, c.data, a.data)
-  c.precision = min(a.precision, c.precision)
-  return c
-end
-
 function sub!(c::LocalFieldElem{S, T}, a::LocalFieldElem{S, T}, b::LocalFieldElem{S, T}) where {S <: FieldElem, T <: LocalFieldParameter}
   check_parent(a, b)
   c.parent = a.parent

diff --git a/src/LocalField/PowerSeries.jl b/src/LocalField/PowerSeries.jl
@@ -305,11 +305,6 @@ function add!(a::LaurentSeriesFieldValuationRingElem, b::LaurentSeriesFieldValua
   return a
 end
 
-function addeq!(a::LaurentSeriesFieldValuationRingElem, b::LaurentSeriesFieldValuationRingElem)
-  a.a = addeq!(data(a), data(b))
-  return a
-end
-
 ################################################################################
 #
 #  Promotion

diff --git a/src/LocalField/ResidueRing.jl b/src/LocalField/ResidueRing.jl
@@ -381,13 +381,6 @@ function add!(c::LocalFieldValuationRingResidueRingElem, a::LocalFieldValuationR
   return c
 end
 
-function addeq!(a::LocalFieldValuationRingResidueRingElem, b::LocalFieldValuationRingResidueRingElem)
-  @req parent(a) === parent(b) "Parents do not match"
-  a.a = addeq!(data(a), data(b))
-  a.a = setprecision!(a.a, _exponent(parent(a)))
-  return a
-end
-
 ################################################################################
 #
 #  Promotion

diff --git a/src/LocalField/Ring.jl b/src/LocalField/Ring.jl
@@ -339,11 +339,6 @@ function add!(a::LocalFieldValuationRingElem, b::LocalFieldValuationRingElem, c:
   return a
 end
 
-function addeq!(a::LocalFieldValuationRingElem, b::LocalFieldValuationRingElem)
-  a.x = addeq!(data(a), data(b))
-  return a
-end
-
 ################################################################################
 #
 #  Promotion