Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dorado aligner #1030

Open
iiSeymour opened this issue Mar 13, 2023 · 3 comments
Open

dorado aligner #1030

iiSeymour opened this issue Mar 13, 2023 · 3 comments

Comments

@iiSeymour
Copy link
Contributor

Hey @lh3

We are starting to add alignment support to dorado and I would like to get some patches upstreamed if possible.

The following pull requests #1028 #1029 fix the Windows compatibility in minimap2 v2.24 (and closes #818 for v2.22).

I've put together the follwing repo that applies these patches and builds minimap2 on Linux, Windows and Mac.

See https://github.com/nanoporetech/ont-minimap2.

As part of this work, I'd also like to get map-ont updated as per #1004. I can send another pull request for this if it's something you're interested in?

@tijyojwad
Copy link
Contributor

Hi @lh3 - we have another patch to get access to the rep_len attributes in the thread buffer structure. Would you be open to accepting that as well?

@lh3
Copy link
Owner

lh3 commented Apr 18, 2023

I am happy to accept a patch for that.

@iiSeymour
Copy link
Contributor Author

Added #1048

@ghost ghost mentioned this issue Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants