Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: alignment support with supplementary alignments? #130

Closed
sklages opened this issue Mar 21, 2023 · 7 comments
Closed

Q: alignment support with supplementary alignments? #130

sklages opened this issue Mar 21, 2023 · 7 comments
Assignees
Labels
question Issue is a question

Comments

@sklages
Copy link

sklages commented Mar 21, 2023

When you are implementing alignment support with minimap2[1] will you keep supplementary alignments? At least as an option?
In bonito these alignments are removed and not present in the final BAM file [2].
That's why we are currently separating the basecalling step from the alignment step in our current "bonito workflow"..

[1] lh3/minimap2#1030
[2] nanoporetech/bonito#318

@iiSeymour iiSeymour added the question Issue is a question label Mar 21, 2023
@iiSeymour iiSeymour self-assigned this Mar 21, 2023
@iiSeymour
Copy link
Member

@sklages I'm working through the implementation of this currently so thanks for raising. Yes, I can make supplementary alignments available.

@sklages
Copy link
Author

sklages commented May 19, 2023

@iiSeymour - I haven't built/tested yet, but does dorado keep supplementary alignments in v0.3.0?

@tijyojwad
Copy link
Collaborator

Hi @sklages - yes supplementary alignments should be there in the output. Let us know if you see otherwise

@iiSeymour
Copy link
Member

dorado's aligned output matches minimap2 w.r.t sec/sup records and included tags.

@ziphra
Copy link

ziphra commented Jul 5, 2023

Hi, I think dorado aligned bams miss the SA tag which gives information about supplementary alignments. I used v0.3.1. This is required for some variant callers I believe. At least, sniffles needs it to call translocation.

@tijyojwad
Copy link
Collaborator

Hi @ziphra - thank you for highlighting this! SA:Z is indeed missing. We will add it to the next release

@tijyojwad tijyojwad reopened this Jul 31, 2023
@tijyojwad tijyojwad assigned tijyojwad and unassigned iiSeymour Jul 31, 2023
@iiSeymour
Copy link
Member

@ziphra the SA tag is now present in the v0.3.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue is a question
Projects
None yet
Development

No branches or pull requests

4 participants