Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python mappy Aligner doesn't handle best_n properly #117

Closed
wukevin opened this issue Feb 17, 2018 · 1 comment
Closed

Python mappy Aligner doesn't handle best_n properly #117

wukevin opened this issue Feb 17, 2018 · 1 comment
Labels
bug

Comments

@wukevin
Copy link

wukevin commented Feb 17, 2018

When attempting to create an Aligner object in Python using the invocation:

minimap = mappy.Aligner(GENOME_MMI, preset="splice", best_n=5)

The following error is produced:

File "python/mappy.pyx", line 114, in mappy.Aligner.__cinit__
AttributeError: 'mappy.Aligner' object has no attribute 'best_n'

Mappy version 2.8, Python 2.7.11
lh3 added a commit that referenced this issue Feb 17, 2018
@lh3
fixed a typo in mappy (#117)
090361c
@lh3 lh3 added the bug label Feb 17, 2018
@lh3
Copy link
Owner

lh3 commented Feb 17, 2018

That's a typo. I have changed the code, but haven't tested it yet. See the master.

@lh3 lh3 closed this as completed Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lh3 @wukevin