Check for whether output is correctly written #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `puts()` returns an error (e.g., writing to a full disk), then immediately `exit(1)`. Also, flush the output at the end and check if that operation was successful before exiting with a zero error code. fixes lh3#103
|
I'd prefer |
lh3
added a commit
that referenced
this pull request
Mar 22, 2018
|
Thanks for this PR. I reimplemented in a slightly different way. Note that I am not propagating error code. I know a library should not exit in the middle. However, minimap2 may need quite a bit code refactoring to behave like a proper library. Hope this happens some day. Addressed via 623b5d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
puts()returns an error (e.g., writing to a full disk), thenimmediately
exit(1). Also, flush the output at the end and check ifthat operation was successful before exiting with a zero error code.
fixes #103
Calling
exit(1)from within a pthread is a bit heavy handed, but it's allowed by the pthread docs and works as expected (stops all threads and exits with the given error code).