Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart test #203

Closed
wants to merge 30 commits into from
Closed

Multipart test #203

wants to merge 30 commits into from

Conversation

philres
Copy link

@philres philres commented Jul 23, 2018

No description provided.

lh3 added a commit that referenced this pull request Jul 25, 2018
@lh3
Copy link
Owner

lh3 commented Jul 25, 2018

It seems that this PR involves three components: 1) #189 which has been reimplemented; 2) MD tag in mappy; 3) arm64 support in mappy. I have reimplemented 2) and 3) as well. Note that for 2), you need to call mappy.Aligner.map(seq, MD=True). Mappy doesn't generate the MD tag by default.

I am closing this PR now. You can try the master. If you have issues, please create new issues. Thank you.

@lh3 lh3 closed this Jul 25, 2018
@philres
Copy link
Author

philres commented Jul 25, 2018

Hi Heng,

I'm so sorry, this was not meant to be a pull request. It is just a branch form my fork I use to play around with. I was planing to open pull request for 2) and 3) at some point but separately and after some refactoring. I have to check how I managed to, accidentally, open a pull request for this branch.

Sorry again, and thank you very much for implementing 1), 2), 3). This will make things much easier for me!

Thanks,
Philipp

@lh3
Copy link
Owner

lh3 commented Jul 26, 2018

Never mind. I am glad that you sent this PR; otherwise I would implement these useful features much later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants