Build with -std=c11 instead of -std=gnu11 #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This struct is obsolete and passing `NULL` is the recommended approach. http://man7.org/linux/man-pages/man2/gettimeofday.2.html
* `asm` requires explicitly enabling GNUtensions, as `asm` is not a recognized C identifier.
* By defining `_XOPEN_SOURCE` to be 600, we do not have to pass `-std=gnu11` when building Minimap2, and can use `-std=c11` instead.
|
Minimap2 can be compiled with gcc/clang -std=c99/c11 and g++/clang++ -std=c++98/c++11/c++14. g++ -std=c++17 also works, but clang++ -std=c++17 fails as |
|
@lh3 very nice. Maybe we can remove |
lh3
added a commit
that referenced
this pull request
Nov 19, 2018
|
Done. minimap2 can now be compiled with "clang++ -std=c++17". Note that minimap2 still uses some compiler extensions like __sync_fetch_and_add() and __asm__. |
|
@lh3 thanks for your dedication and commitment. Compiler extensions are fine, so long they don't include prohibited language features (such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lh3
We generally like to build our codebases against ISO C as much as possible and avoid GNUisms. With this PR, minimap2 can be compiled with
-std=c11now. This makes bundling minimap2 in other codebases much easier.