[fix][test] Fix flaky test BrokerServiceAutoSubscriptionCreationTest (a…

…pache#22190)
lhotari · Mar 4, 2024 · 8c7c978 · 8c7c978
1 parent ccc2ea6
commit 8c7c978
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/...test/java/org/apache/pulsar/broker/service/BrokerServiceAutoSubscriptionCreationTest.java b/...test/java/org/apache/pulsar/broker/service/BrokerServiceAutoSubscriptionCreationTest.java
@@ -28,6 +28,7 @@
 import org.apache.pulsar.client.api.PulsarClientException;
 import org.apache.pulsar.common.naming.TopicName;
 import org.apache.pulsar.common.policies.data.AutoSubscriptionCreationOverride;
+import org.awaitility.Awaitility;
 import org.testng.Assert;
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.AfterMethod;
@@ -159,15 +160,19 @@ public void testDynamicConfigurationTopicAutoSubscriptionCreation()
             throws PulsarAdminException, PulsarClientException {
         pulsar.getConfiguration().setAllowAutoTopicCreation(false);
         pulsar.getConfiguration().setAllowAutoSubscriptionCreation(true);
-        admin.brokers().updateDynamicConfiguration("allowAutoSubscriptionCreation", "false");
+        String allowAutoSubscriptionCreation = "allowAutoSubscriptionCreation";
+        admin.brokers().updateDynamicConfiguration(allowAutoSubscriptionCreation, "false");
         String topicString = "persistent://prop/ns-abc/non-partitioned-topic" + UUID.randomUUID();
         String subscriptionName = "non-partitioned-topic-sub";
         admin.topics().createNonPartitionedTopic(topicString);
         Assert.assertThrows(PulsarClientException.class,
                 ()-> pulsarClient.newConsumer().topic(topicString).subscriptionName(subscriptionName).subscribe());
-        admin.brokers().updateDynamicConfiguration("allowAutoSubscriptionCreation", "true");
-        pulsarClient.newConsumer().topic(topicString).subscriptionName(subscriptionName).subscribe();
-        assertTrue(admin.topics().getSubscriptions(topicString).contains(subscriptionName));
+        admin.brokers().updateDynamicConfiguration(allowAutoSubscriptionCreation, "true");
+        Awaitility.await().untilAsserted(() -> {
+            Assert.assertEquals(admin.brokers().getAllDynamicConfigurations().get(allowAutoSubscriptionCreation), "true");
+            pulsarClient.newConsumer().topic(topicString).subscriptionName(subscriptionName).subscribe();
+            assertTrue(admin.topics().getSubscriptions(topicString).contains(subscriptionName));
+        });
     }
 
 }