chore(Common): update the Common.now #55
Closed
+180
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On IE9, perf.now doesn't exists and it throw an error. I updated the function to mach with the gist
| performance.msNow || | ||
| performance.oNow || | ||
| performance.mozNow || | ||
| function() { return new Date().getTime(); }; |
There was a problem hiding this comment.
You should rewrite this line to simply be a reference to Date.now. It outperforms creating a new Date instance and it makes the code cleaner.
Date.now is supported by all ECMAScript 5 browsers (IE 9+).
There was a problem hiding this comment.
If this is migrated to Date.now then it should be compatibility checked as well and Date.getTime() should still be a fallback. Not all clients are capable of supporting IE9+; we use Matter.js on IE6, for instance.
There was a problem hiding this comment.
In that case yes, you could add it as a check before defaulting to new Date().getTime()
If performance is not available we use Date.now If Date.now is not available (IE < 9) we use Date.getTime See commentaries: #55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On IE9, perf.now doesn't exists and it throw an error. I updated the
function to mach with the gist