Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: review for code smell, duplicates, IDE notices #13

Merged
merged 13 commits into from
Sep 17, 2024
Merged

fix: review for code smell, duplicates, IDE notices #13

merged 13 commits into from
Sep 17, 2024

Conversation

caseyw
Copy link
Collaborator

@caseyw caseyw commented Aug 30, 2024 •
edited
Loading

I noticed that there were some code smells, duplicates, and IDE notices in the codebase.

Pretty normal stuff, but I wanted to clean it up a bit while we were in there.

Let me know if anyone has any questions.

@caseyw caseyw marked this pull request as ready for review August 30, 2024 19:35
Wolftousen
Wolftousen previously requested changes Sep 3, 2024
View reviewed changes
src/ChangeLeadTimeGraph.tsx Outdated Show resolved Hide resolved
src/TrendGraph.tsx Outdated Show resolved Hide resolved
src/functions/metricFunctions.tsx Outdated Show resolved Hide resolved
stories/Board.stories.tsx Outdated Show resolved Hide resolved
stories/ChangeFailureRate.stories.tsx Outdated Show resolved Hide resolved
stories/DeploymentFrequency.stories.tsx Outdated Show resolved Hide resolved
stories/MetricEditor.tsx Outdated Show resolved Hide resolved
stories/RecoverTime.stories.tsx Outdated Show resolved Hide resolved
stories/Trends.stories.tsx Outdated Show resolved Hide resolved
stories/useGraph.tsx Outdated Show resolved Hide resolved
@caseyw caseyw enabled auto-merge (squash) September 5, 2024 17:00
@caseyw caseyw disabled auto-merge September 6, 2024 16:10
@caseyw caseyw changed the title chore: review for code smell, duplicates, IDE notices fix: review for code smell, duplicates, IDE notices Sep 6, 2024
@caseyw caseyw dismissed Wolftousen’s stale review September 17, 2024 13:47

I resolved everything mentioned.

tjvkroll
tjvkroll previously approved these changes Sep 17, 2024
View reviewed changes
@caseyw caseyw merged commit 46a5d10 into main Sep 17, 2024
6 checks passed
@caseyw caseyw deleted the code-review branch September 17, 2024 19:19
Wolftousen pushed a commit that referenced this pull request Sep 17, 2024
@semantic-release-bot
chore(release): 1.1.8 [skip ci]
33ca8ac 
## [1.1.8](v1.1.7...v1.1.8) (2024-09-17)

### Bug Fixes

* review for code smell, duplicates, IDE notices ([#13](#13)) ([46a5d10](46a5d10))
@Wolftousen
Copy link
Collaborator

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjvkroll tjvkroll tjvkroll approved these changes

@Wolftousen Wolftousen Awaiting requested review from Wolftousen

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseyw @Wolftousen @tjvkroll