feature: inbuilt support for for int32/float32/[]byte slices in pq.Array #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shivam010 could you rebase to the latest master and resolve the conflicts. Would love to see this being pulled. |
…/float32/[]byte slices
|
@guenhter Rebased |
|
Closes #588 |
|
@mjibson are you willing to merge this PR? |
Closed
|
@mjibson When do you think you make a new release so that this is then contained? |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inbuilt support for scanner and valuer in pq.Array for
int32orfloat32or[]byteadded, as described in issue #875