Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyramid18 geometry + LAGRANGE support #3458

Merged
merged 17 commits into from
Dec 14, 2022
Merged

Conversation

roystgnr
Copy link
Member

@roystgnr roystgnr commented Dec 8, 2022

No description provided.

@roystgnr
Copy link
Member Author

roystgnr commented Dec 8, 2022

Ha! I'm the first one to run rebuild_include_HEADERS.sh since win_gettimeofday.h was introduced, aren't I?

@moosebuild
Copy link

moosebuild commented Dec 9, 2022

Job Coverage on 82b6cb2 wanted to post the following:

Coverage

b72444 #3458 82b6cb
Total Total +/- New
Rate 59.88% 59.96% +0.07% 78.25%
Hits 48529 48749 +220 223
Misses 32510 32556 +46 62

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 78.25% is less than the suggested 90.0%

This comment will be updated on new commits.

@roystgnr roystgnr merged commit 70e9c97 into libMesh:devel Dec 14, 2022
@roystgnr roystgnr deleted the side_pyramids branch December 14, 2022 23:41
@roystgnr
Copy link
Member Author

Apologies to @loganharbour - rebasing #3432 on this is certain to break it until the additional overloads for his new APIs are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants